"Dock unpinned" option can be confusing

[elliette]

At the top of every DevTools panel is the option to switch the dock from "pinned" (default) to "unpinned"

Three dots > View mode > Dock unpinned

When a panel is put into "dock unpinned" mode, clicking on a file automatically closes the panel. This is especially confusing for the Property Editor panel, since clicking in a file is how to update the selected widget in the Property Editor.

We should consider:

1. Removing the view mode option
2. Warning if the user is in dock unpinned mode

FYI @jwren

[helin24]

We have some options here:

1. We can detect dock unpinned mode with toolWindow.getType() (docked or floating) and toolWindow.isAutoHide() (true if unpinned)
2. I'm able to call toolWindow.setAutoHide(false) to programmatically make the dock pinned

However, I don't know if we can remove the unpinned option from the menu. I have not found one but @alexander-doroshko do you know if there's an API for this?

[alexander-doroshko]

I'm afraid I haven't found a way to remove this option from the menu. I hope people don't really use it.