"Packages get" hangs with package from a SSH based private git repository

[raveesh-me]

Steps to Reproduce

• Upload a dart package to a private github/gitlab repo
• Set up SSH based authentication
• Add the dependency as:

  my_package:
    git: git@gitlab.com:company/my_package.git

When run in terminal as flutter packages get,

It runs fine. When accessing hosted repository, it will ask for passphrase for the private SSH key

When run using the Packages get button on top left of editor

/home/raveesh/MyCode/sdk/flutter/bin/flutter --no-color packages get
Running "flutter packages get" in guru_app...      

comes up in the messages tab, and the plugin has no way to ask for a SSH password if prompted.
This is where the flutter command hangs and all flutter commands fails because packages get does not release the lock

Current Solution

run:

sudo killall dart

and then run flutter packages get manually in terminal.

Version info

/home/raveesh/MyCode/sdk/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, v1.0.0, on Linux, locale en_IN)
    • Flutter version 1.0.0 at /home/raveesh/MyCode/sdk/flutter
    • Framework revision 5391447fae (6 weeks ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /home/raveesh/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /home/raveesh/Android/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] Android Studio (version 3.2)
    • Android Studio at /home/raveesh/Android/android-studio
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.30.2)
    • VS Code at /usr/share/code
    • Flutter extension version 2.21.1

[✓] Connected device (1 available)
    • Moto G 5 Plus • 192.168.1.4:5555 • android-arm • Android 8.1.0 (API 27)

• No issues found!
Process finished with exit code 0

[eseidelGoogle]

It's possible Dart should do better here. But this also sounds like a common problem with ssh for which (as I understand it) ssh-agent exists to solve?

@zoechi I suspect this belongs in the pub repository and it's possible that pub should be calling git with different flags or environment to force it to error out instead of attempting to talk to an input stream which is not there. For example, pub may need to set stdin to null or /dev/null when calling git to make it do the right thing.

[zoechi]

I also think this should be reported in https://github.com/dart-lang/pub/issues

[raveesh-me]

Not setting a password for SSH key also works 🤣

[zoechi]

@eseidelGoogle in case you wanted me to move the issue, I can't do that, only between repos where I'm member, and I'm not a member of dart-lang/... repos.

[raveesh-me]

I will open a new issue in that case.

[raveesh-me]

Closed in favor of: dart-lang/pub#2026

[jonasfj]

I note on dart-lang/pub#2026 that pub forwards the system SSH_AGENT.
Probably the editor plugin needs to ensure that:

• pub is not invoked in an interactive shell that users can't interact with, or that,
• DISPLAY and SSH_ASKPASS is set if calling in an non-interactive shell.

See: https://man.openbsd.org/ssh#SSH_ASKPASS

But I'll admit there is a lot of subtle issues here, and getting this to work across platforms is not easy.

[terrylucas]

Steve this seems like an enhancement/feature. However, I'm not sure of the work involved in the plugin seems like it could be a bit tricky. I've marked as an enhancement for now but feel free to disagree.