Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Removed outdated deprecation comments #9087

Merged
merged 1 commit into from
May 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,6 @@ public boolean onRequestPermissionsResult(
return flutterView.getPluginRegistry().onRequestPermissionsResult(requestCode, permissions, grantResults);
}

/*
* Method onRequestPermissionResult(int, String[], int[]) was made
* unavailable on 2018-02-28, following deprecation. This comment is left as
* a temporary tombstone for reference, to be removed on 2018-03-28 (or at
* least four weeks after release of unavailability).
*
* https://github.com/flutter/flutter/wiki/Changelog#typo-fixed-in-flutter-engine-android-api
*/

@Override
public boolean onActivityResult(int requestCode, int resultCode, Intent data) {
return flutterView.getPluginRegistry().onActivityResult(requestCode, resultCode, data);
Expand Down
18 changes: 0 additions & 18 deletions shell/platform/android/io/flutter/app/FlutterPluginRegistry.java
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,6 @@ public Registrar publish(Object value) {
return this;
}

/*
* Method addRequestPermissionResultListener(RequestPermissionResultListener)
* was made unavailable on 2018-02-28, following deprecation.
* This comment is left as a temporary tombstone for reference, to be removed
* on 2018-03-28 (or at least four weeks after release of unavailability).
*
* https://github.com/flutter/flutter/wiki/Changelog#typo-fixed-in-flutter-engine-android-api
*/

@Override
public Registrar addRequestPermissionsResultListener(
RequestPermissionsResultListener listener) {
Expand Down Expand Up @@ -207,15 +198,6 @@ public boolean onRequestPermissionsResult(int requestCode, String[] permissions,
return false;
}

/*
* Method onRequestPermissionResult(int, String[], int[]) was made
* unavailable on 2018-02-28, following deprecation. This comment is left as
* a temporary tombstone for reference, to be removed on 2018-03-28 (or at
* least four weeks after release of unavailability).
*
* https://github.com/flutter/flutter/wiki/Changelog#typo-fixed-in-flutter-engine-android-api
*/

@Override
public boolean onActivityResult(int requestCode, int resultCode, Intent data) {
for (ActivityResultListener listener : mActivityResultListeners) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,26 +163,6 @@ interface Registrar {
*/
Registrar addRequestPermissionsResultListener(RequestPermissionsResultListener listener);

/*
* Method addRequestPermissionResultListener(RequestPermissionResultListener listener)
* was made unavailable on 2018-02-28, leaving this comment as a temporary
* tombstone for reference. This comment will be removed on 2018-03-28
* (or at least four weeks after the unavailability is released).
*
* https://github.com/flutter/flutter/wiki/Changelog#typo-fixed-in-flutter-engine-android-api
*
* Adds a callback allowing the plugin to take part in handling incoming
* calls to {@code Activity#onRequestPermissionsResult(int, String[], int[])}
* or {@code android.support.v4.app.ActivityCompat.OnRequestPermissionsResultCallback#onRequestPermissionsResult(int, String[], int[])}.
*
* @param listener a {@link RequestPermissionResultListener} callback.
* @return this {@link Registrar}.

* @deprecated on 2018-01-02 because of misspelling. This method will be made unavailable
* on 2018-02-06 (or at least four weeks after the deprecation is released). Use
* {@link #addRequestPermissionsResultListener(RequestPermissionsResultListener)} instead.
*/

/**
* Adds a callback allowing the plugin to take part in handling incoming
* calls to {@link Activity#onActivityResult(int, int, Intent)}.
Expand Down Expand Up @@ -231,22 +211,6 @@ interface RequestPermissionsResultListener {
boolean onRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults);
}

/*
* interface RequestPermissionResultListener was made unavailable on
* 2018-02-28, leaving this comment as a temporary tombstone for reference.
* This comment will be removed on 2018-03-28 (or at least four weeks after
* the unavailability is released).
*
* https://github.com/flutter/flutter/wiki/Changelog#typo-fixed-in-flutter-engine-android-api
*
* Delegate interface for handling result of permissions requests on
* behalf of the main {@link Activity}.
*
* Deprecated on 2018-01-02 because of misspelling. This interface will be made
* unavailable on 2018-02-06 (or at least four weeks after the deprecation is released).
* Use {@link RequestPermissionsResultListener} instead.
*/

/**
* Delegate interface for handling activity results on behalf of the main
* {@link Activity}.
Expand Down