This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Guard initialization of touch exploration listener #8103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetf
approved these changes
Mar 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 10, 2019
…ngine#8103) (#29117) flutter/engine@9e8f8d0...4e54bc9 git log 9e8f8d0..4e54bc9 --no-merges --oneline 4e54bc9 Guard initialization of touch exploration listener (flutter/engine#8103) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop the roller if necessary.
|
/cc @mklim @matthew-carroll FYI |
| @@ -336,8 +318,29 @@ public void onChange(boolean selfChange, Uri uri) { | |||
| // Tell Flutter whether touch exploration is initially active or not. Then register a listener | |||
| // to be notified of changes in the future. | |||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) { | |||
| touchExplorationStateChangeListener = new AccessibilityManager.TouchExplorationStateChangeListener() { | |||
There was a problem hiding this comment.
Generally, I think we should avoid in-line anonymous definitions beyond anything more compicated than a click handler. If we can't define this up above where it was then we should define it as a static inner class. I will make this change next week.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
)" This reverts commit 516fcb4.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
)" This reverts commit 516fcb4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field initialization breaks older android versions