Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Mark const extern #8077

Merged
merged 2 commits into from
Mar 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ gke_container:
task:
env:
CIRRUS_WORKING_DIR: "/tmp/github_repo"

DEPOT_TOOLS_UPDATE: 0
replace_engine_script: |
cd $ENGINE_PATH/src
rm -r flutter
Expand Down Expand Up @@ -88,7 +88,7 @@ format_and_dart_test_task:

env:
CIRRUS_WORKING_DIR: "/tmp/github_repo"

DEPOT_TOOLS_UPDATE: 0
replace_engine_script: |
cd $ENGINE_PATH/src
rm -r flutter
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* The object passed as the sender is the `FlutterViewController` associated
* with the update.
*/
const NSNotificationName FlutterSemanticsUpdateNotification = @"FlutterSemanticsUpdate";
extern NSNotificationName const FlutterSemanticsUpdateNotification;

/**
* A `UIViewController` implementation for Flutter views.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
#include "flutter/shell/platform/darwin/ios/framework/Source/platform_message_response_darwin.h"
#include "flutter/shell/platform/darwin/ios/platform_view_ios.h"

NSNotificationName const FlutterSemanticsUpdateNotification = @"FlutterSemanticsUpdate";

@implementation FlutterViewController {
std::unique_ptr<fml::WeakPtrFactory<FlutterViewController>> _weakFactory;
fml::scoped_nsobject<FlutterEngine> _engine;
Expand Down