This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Android Embedding PR 11: Add FlutterEngine to FlutterFragment. #7972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-carroll
requested review from
mklim,
jason-simmons and
DaveShuckerow
jason-simmons
approved these changes
Feb 27, 2019
dnfield
reviewed
Feb 28, 2019
| * By default, this method returns a standard {@link FlutterEngine} without any modification. | ||
| */ | ||
| @NonNull | ||
| protected FlutterEngine onCreateFlutterEngine(@NonNull Context context) { |
There was a problem hiding this comment.
The naming of this seems awkward to me. I think this should just be called createFlutterEngine. Having a non-void method called onCreate seems unusual.
There was a problem hiding this comment.
This is really a nit though, feel free to disregard if it fits some other pattern that I'm just not aware of.
There was a problem hiding this comment.
The convention I was trying to follow here is similar to the onCreateView() method in Fragments. There's a primary method invoked in the superclass, in this case called createFlutterEngine(), which then internally invokes a subclass hook, in this case called onCreateFlutterEngine(). Does that make sense?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2019
flutter/engine@9b92476...5194919 git log 9b92476..5194919 --no-merges --oneline 5194919 Roll src/third_party/skia 1179d5dfaf8d..b7b2da871e95 (1 commits) (flutter/engine#7996) 58ce0ff Roll src/third_party/skia 90043480b587..1179d5dfaf8d (3 commits) (flutter/engine#7995) 72cbe69 Fix two typos in embedder.h (flutter/engine#7993) 2360b45 Android Embedding PR 11: Add FlutterEngine to FlutterFragment. (flutter/engine#7972) df03ec7 Roll src/third_party/skia 0cedddc1420b..90043480b587 (1 commits) (flutter/engine#7994) 4a148cd Roll src/third_party/skia 67d87128fd00..0cedddc1420b (10 commits) (flutter/engine#7992) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.