Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix versions implementation #7726

Merged
merged 1 commit into from
Feb 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ui/versions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void GetVersions(Dart_NativeArguments args) {
}

void Versions::RegisterNatives(tonic::DartLibraryNatives* natives) {
natives->Register({{"Versions_getVersions", GetVersions, 1, true}});
natives->Register({{"Versions_getVersions", GetVersions, 0, true}});
}

} // namespace blink
5 changes: 1 addition & 4 deletions testing/dart/versions_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// HACK: pretend to be dart.ui in order to access its internals
library dart.ui;
import 'dart:ui';

import 'package:test/test.dart';

part '../../lib/ui/versions.dart';

bool _isNotEmpty(String s) {
if (s == null || s.isEmpty) {
return false;
Expand Down