This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support for saving goal weight #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
collinjackson
added a commit
that referenced
this pull request
Aug 20, 2015
Support for saving goal weight
| String get goalWeightText { | ||
| if (userData.goalWeight == null || userData.goalWeight == 0.0) | ||
| return "None"; | ||
| else |
There was a problem hiding this comment.
else is not needed here.
|
lgtm. Don't need to fix the nits. Sorry for the late review. |
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
This allows us to avoid issues like those described in flutter#713 where we want users to be able to share errors between different logical tests.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Make addTearDown() play nice with setUpAll()
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
…image_vu Add VU for depth/stencil image descriptor
aam
added a commit
to aam/engine
that referenced
this pull request
Apr 18, 2023
Changes since last roll: ``` 059d155 [dart] Add identifier needed for zlib roll (flutter#718) 459d3e5 Bump github/codeql-action from 2.2.11 to 2.2.12 (flutter#716) 91f1ba5 Bump actions/checkout from 3.5.1 to 3.5.2 (#715) 2e5c483 Bump actions/checkout from 3.5.0 to 3.5.1 (flutter#714) a5af13d Remove codeql. (flutter#713) ```
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
Bug: flutter/flutter#124702 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.