Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Member

Skia privately brings in its own copy. https://skia-review.googlesource.com/c/skia/+/172147

@chinmaygarde
Copy link
Member Author

Not that this PR is to the skia-master branch.

@chinmaygarde
Copy link
Member Author

@liyuqian Are the Cirrus bots wired to take into account the branch from the PR? Or is this still running off of master? I wasn't expecting these jobs to have been triggered.

@chinmaygarde chinmaygarde merged commit 93f75f2 into flutter:skia-master Nov 28, 2018
@chinmaygarde chinmaygarde deleted the novkheader branch November 28, 2018 23:31
@liyuqian
Copy link
Contributor

My impression is that Cirrus uses whatever branch your local change is based on. If your local change is based on skia-master, then it uses skia-master. If your local change is based on master, then it uses master. If your local change is based on an old master branch, then it uses that old master branch.

@liyuqian
Copy link
Contributor

BTW, can we also remove flutter/vulkan/skia_vulkan_header.h from our repo since it's no longer used?

@chinmaygarde
Copy link
Member Author

No. We still need that header because the embedder implementation needs the Vulkan headers. We just dont need to forward these over to Skia.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants