This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Require the GLES multisampled_render_to_texture2 extension for offscreen MSAA #56997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for offscreen MSAA Offscreen MSAA needs the ability to create multisample depth and stencil attachments.
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2024
… extension for offscreen MSAA (flutter/engine#56997)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2024
… extension for offscreen MSAA (flutter/engine#56997)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2024
… extension for offscreen MSAA (flutter/engine#56997)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2024
… extension for offscreen MSAA (flutter/engine#56997)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2024
… extension for offscreen MSAA (flutter/engine#56997)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 6, 2024
…159909) flutter/engine@31ba1e0...d42645f 2024-12-06 30870216+gaaclarke@users.noreply.github.com Reland: Replaces bespoke call captures from mock gles with gmock (flutter/engine#57019) 2024-12-06 skia-flutter-autoroll@skia.org Roll Skia from c9647f13cded to 0d94e966268b (36 revisions) (flutter/engine#57023) 2024-12-06 chris@bracken.jp iOS: add null check on create impeller context (flutter/engine#56952) 2024-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 9c9a333c496c to 67ce49b905f7 (2 revisions) (flutter/engine#57013) 2024-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Replaces bespoke call captures from mock gles with gmock (#56995)" (flutter/engine#57016) 2024-12-06 30870216+gaaclarke@users.noreply.github.com Replaces bespoke call captures from mock gles with gmock (flutter/engine#56995) 2024-12-06 jason-simmons@users.noreply.github.com [Impeller] Require the GLES multisampled_render_to_texture2 extension for offscreen MSAA (flutter/engine#56997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
… for offscreen MSAA (flutter/engine#56997) Offscreen MSAA needs the ability to create multisample depth and stencil attachments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offscreen MSAA needs the ability to create multisample depth and stencil attachments.