Cleanup refactoring in FlKeyboardManager #56956
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: code refactor with no semantic change |
|
@robert-ancell does this other PR contain the same changes as this one? Maybe an accident? |
The other PR is built on top of these changes. |
…159959) flutter/engine@82d7c1b...292146a 2024-12-08 robert.ancell@canonical.com Cleanup refactoring in FlKeyboardManager (flutter/engine#56956) 2024-12-08 skia-flutter-autoroll@skia.org Roll Skia from 76c51c6e13df to 96b018c1088a (2 revisions) (flutter/engine#57052) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Remove pending keyboard event ID and use the object directly. Use references to make sure FlKeyboardManagerData is freed. Refactor marking events as handled
4 participants
Remove pending keyboard event ID and use the object directly.
Use references to make sure FlKeyboardManagerData is freed.
Refactor marking events as handled