This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Started only loading gles3 functions if we have a gles3 context #56636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| @@ -121,7 +121,16 @@ ProcTableGLES::ProcTableGLES( // NOLINT(google-readability-function-size) | |||
| reinterpret_cast<decltype(proc_ivar.function)>(fn_ptr); \ | |||
| proc_ivar.error_fn = error_fn; \ | |||
| } | |||
| FOR_EACH_IMPELLER_GLES3_PROC(IMPELLER_PROC); | |||
|
|
|||
| GLint major_version = 0; | |||
There was a problem hiding this comment.
Use description_->GetGlVersion().IsAtLeast(...)
|
I'm going to wait to land this until #56596 does, since it has a good test to make sure this doesn't break anything. |
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
I should have rebased before landing, oh well I tested it locally and is almost surely good. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2024
…159093) flutter/engine@9686de1...766370b 2024-11-18 30870216+gaaclarke@users.noreply.github.com Started only loading gles3 functions if we have a gles3 context (flutter/engine#56636) 2024-11-18 30870216+gaaclarke@users.noreply.github.com [impeller] enable framebuffer blit when available (flutter/engine#56596) 2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 7594233ff914 to 0b74d5c3eb4f (4 revisions) (flutter/engine#56678) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2024
…159097) flutter/engine@9686de1...878f593 2024-11-18 chris@bracken.jp EmbedderTest: Extract backend-specific user_data (flutter/engine#56642) 2024-11-18 skia-flutter-autoroll@skia.org Roll Dart SDK from ae5111067032 to 625e0a9cb67a (1 revision) (flutter/engine#56679) 2024-11-18 30870216+gaaclarke@users.noreply.github.com Started only loading gles3 functions if we have a gles3 context (flutter/engine#56636) 2024-11-18 30870216+gaaclarke@users.noreply.github.com [impeller] enable framebuffer blit when available (flutter/engine#56596) 2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 7594233ff914 to 0b74d5c3eb4f (4 revisions) (flutter/engine#56678) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2024
…159097) flutter/engine@9686de1...878f593 2024-11-18 chris@bracken.jp EmbedderTest: Extract backend-specific user_data (flutter/engine#56642) 2024-11-18 skia-flutter-autoroll@skia.org Roll Dart SDK from ae5111067032 to 625e0a9cb67a (1 revision) (flutter/engine#56679) 2024-11-18 30870216+gaaclarke@users.noreply.github.com Started only loading gles3 functions if we have a gles3 context (flutter/engine#56636) 2024-11-18 30870216+gaaclarke@users.noreply.github.com [impeller] enable framebuffer blit when available (flutter/engine#56596) 2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 7594233ff914 to 0b74d5c3eb4f (4 revisions) (flutter/engine#56678) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ter/engine#56636) test: exists in flutter/engine#56596 fixes: flutter#158995 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This was referenced May 30, 2025
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: exists in #56596
fixes: flutter/flutter#158995
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.