Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[macos] early return to suppress clang-tidy warning #56588

Merged
merged 3 commits into from
Nov 15, 2024
Merged

[macos] early return to suppress clang-tidy warning #56588

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab1ad74
[macos]fix clang-tidy warning for NSAssert
hellohuanlin Nov 14, 2024
4e6826f
Update shell/platform/darwin/macos/framework/Source/FlutterChannelKey…
hellohuanlin Nov 14, 2024
d447514
format
hellohuanlin Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponder.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,13 @@ - (void)handleEvent:(NSEvent*)event callback:(FlutterAsyncKeyCallback)callback {
return;
}
break;
default: {
NSAssert(false, @"Unexpected key event type (got %lu).", event.type);
callback(false);
}
default:
[[unlikely]] {
NSAssert(false, @"Unexpected key event type (got %lu).", event.type);
callback(false);
// This should not happen. Return to suppress clang-tidy warning on `type` being nil.
return;
}
}
_previouslyPressedFlags = modifierFlags;
NSMutableDictionary* keyMessage = [@{
Expand Down