Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Android] choose 24 bit depth buffer. #56553

Merged
merged 3 commits into from
Nov 14, 2024
Merged

[Android] choose 24 bit depth buffer. #56553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
321e93e
[Android] choose 24 bit depth buffer.
jonahwilliams Nov 13, 2024
498e9e2
is this a test?
jonahwilliams Nov 13, 2024
fd8476d
++
jonahwilliams Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions impeller/toolkit/egl/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ enum class StencilBits {
enum class DepthBits {
kZero = 0,
kEight = 8,
kTwentyFour = 24,
};

enum class SurfaceType {
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/android/android_context_gl_impeller.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ AndroidContextGLImpeller::AndroidContextGLImpeller(
impeller::egl::ConfigDescriptor desc;
desc.api = impeller::egl::API::kOpenGLES2;
desc.color_format = impeller::egl::ColorFormat::kRGBA8888;
desc.depth_bits = impeller::egl::DepthBits::kZero;
desc.depth_bits = impeller::egl::DepthBits::kTwentyFour;
desc.stencil_bits = impeller::egl::StencilBits::kEight;
desc.samples = impeller::egl::Samples::kFour;

Expand Down
2 changes: 2 additions & 0 deletions shell/platform/android/android_context_gl_impeller_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ bool GetEGLConfigForSurface(EGLint surface_bit, EGLConfig* result) {
EGL_GREEN_SIZE, 8,
EGL_BLUE_SIZE, 8,
EGL_ALPHA_SIZE, 8,
EGL_DEPTH_SIZE, 24,
EGL_STENCIL_SIZE, 8,
EGL_NONE,
// clang-format on
};
Expand Down