Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fml: Improve CFTest.SupportsCustomRetainRelease test #56480

Merged
merged 1 commit into from
Nov 10, 2024
Merged

fml: Improve CFTest.SupportsCustomRetainRelease test #56480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 24 additions & 20 deletions fml/platform/darwin/cf_utils_unittests.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,19 @@

namespace fml {

// Test state used in CFTest.SupportsCustomRetainRelease.
struct CFRefTestState {
bool retain_called;
bool release_called;
};

// Template specialization used in CFTest.SupportsCustomRetainRelease.
template <>
struct CFRefTraits<int64_t> {
static bool retain_called;
static bool release_called;

static constexpr int64_t kNullValue = 0;
static void Retain(int64_t instance) { retain_called = true; }
static void Release(int64_t instance) { release_called = true; }
struct CFRefTraits<CFRefTestState*> {
static constexpr CFRefTestState* kNullValue = nullptr;
static void Retain(CFRefTestState* instance) { instance->retain_called = true; }
static void Release(CFRefTestState* instance) { instance->release_called = true; }
};
bool CFRefTraits<int64_t>::retain_called = false;
bool CFRefTraits<int64_t>::release_called = false;

namespace testing {

Expand Down Expand Up @@ -98,18 +99,21 @@
}

TEST(CFTest, SupportsCustomRetainRelease) {
CFRef<int64_t> ref(1);
ASSERT_EQ(ref.Get(), 1);
ASSERT_FALSE(CFRefTraits<int64_t>::retain_called);
ASSERT_FALSE(CFRefTraits<int64_t>::release_called);
CFRefTestState instance{};
CFRef<CFRefTestState*> ref(&instance);
ASSERT_EQ(ref.Get(), &instance);
ASSERT_FALSE(instance.retain_called);
ASSERT_FALSE(instance.release_called);
ref.Reset();
ASSERT_EQ(ref.Get(), 0);
ASSERT_TRUE(CFRefTraits<int64_t>::release_called);
ref.Retain(2);
ASSERT_EQ(ref.Get(), 2);
ASSERT_TRUE(CFRefTraits<int64_t>::retain_called);
CFRefTraits<int64_t>::retain_called = false;
CFRefTraits<int64_t>::release_called = false;
ASSERT_EQ(ref.Get(), nullptr);
ASSERT_FALSE(instance.retain_called);
ASSERT_TRUE(instance.release_called);

CFRefTestState other_instance{};
ref.Retain(&other_instance);
ASSERT_EQ(ref.Get(), &other_instance);
ASSERT_TRUE(other_instance.retain_called);
ASSERT_FALSE(other_instance.release_called);
}

} // namespace testing
Expand Down