This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Prioritize split font fallbacks over monolythic ones. #56187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
reviewed
Oct 29, 2024
ditman
changed the title
mdebbar
reviewed
Oct 29, 2024
mdebbar
reviewed
Oct 29, 2024
* Renames "availableFonts" in _process*Fonts to "requestedFonts". * Asserts that a single font is downloaded for a single char in test. * Fixes analysis issue in test.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 30, 2024
…157875) flutter/engine@57ed5d3...906a7ad 2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 03600bc22ab8 to d022fe64116f (1 revision) (flutter/engine#56237) 2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 948b01e28f48 to 03600bc22ab8 (1 revision) (flutter/engine#56236) 2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from b319b2e53bfa to 36aed3607108 (2 revisions) (flutter/engine#56235) 2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 1a47627e627a to 948b01e28f48 (1 revision) (flutter/engine#56231) 2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 5410f1c6f86c to 1a47627e627a (1 revision) (flutter/engine#56230) 2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 70eca740f23f to b319b2e53bfa (1 revision) (flutter/engine#56229) 2024-10-30 chris@bracken.jp iOS: make unopt debug builds unopt and debug (flutter/engine#56226) 2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 7385b2d99fe9 to 5410f1c6f86c (1 revision) (flutter/engine#56227) 2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from fcc2bc69db3e to 70eca740f23f (2 revisions) (flutter/engine#56225) 2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 6e0c0a255166 to 7385b2d99fe9 (5 revisions) (flutter/engine#56222) 2024-10-29 aam@google.com Roll buildroot to 3f1a1f0. (flutter/engine#56214) 2024-10-29 ditman@gmail.com [web] Prioritize split font fallbacks over monolythic ones. (flutter/engine#56187) 2024-10-29 skia-flutter-autoroll@skia.org Roll Skia from 5758d9c344e3 to 6e0c0a255166 (3 revisions) (flutter/engine#56215) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…engine#56187) Moves "split" font fallbacks (woff2) over "monolythic" ones (ttf) when resolving fonts. Fixes flutter#157763 It makes flutter web prefer "Noto Color Emoji" over "Noto Sans Symbols" when rendering emoji, for example. This also changes the methods that process the font lists so they *return* the fonts they processed, instead of causing a side effect on an incoming array. --- CIPD Upload log ``` 398 sets covering 22287 ranges Uploading fallback fonts to CIPD with hash 0570a0ea824083da79de07b131fc5df7f55dad4d6cba2ee704912ce7e4ce812a Enumerating files to zip... Instance: flutter/flutter_font_fallbacks:6jWhR90elvOjT1bwCe57CrNWbsGrvOzMONf9_bS8w5IC Setting new fallback fonts deps version to 0570a0ea824083da79de07b131fc5df7f55dad4d6cba2ee704912ce7e4ce812a ``` Link to uploaded bundle: * https://chrome-infra-packages.appspot.com/p/flutter/flutter_font_fallbacks/+/6jWhR90elvOjT1bwCe57CrNWbsGrvOzMONf9_bS8w5IC --- [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves "split" font fallbacks (woff2) over "monolythic" ones (ttf) when resolving fonts.
Fixes flutter/flutter#157763
It makes flutter web prefer "Noto Color Emoji" over "Noto Sans Symbols" when rendering emoji, for example.
This also changes the methods that process the font lists so they return the fonts they processed, instead of causing a side effect on an incoming array.
CIPD Upload log
Link to uploaded bundle:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.