This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] batch submit vulkan command buffers on newer hardware. #55956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
reviewed
Oct 18, 2024
| ->GetCommandQueue() | ||
| ->Submit({std::move(command_buffer_)}) | ||
| .ok()) { | ||
| return false; |
Member
There was a problem hiding this comment.
In al these removed calls, there's a bailout before cleanup work is done (e.g. pass_ is held on to). Should the new EnqueueCommandBuffer() return something other than void (in the fall-through Submit case)?
Contributor
Author
There was a problem hiding this comment.
I updated the enqueue to return bool, which can indicate success still for the backends that don't do the batch submit. In this case, its safe to eagerly null out the pass. and the cmd buffer doesn't need to be nulled out since its already nulled from the std::move.
jtmcdole
approved these changes
Oct 19, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 19, 2024
…157229) flutter/engine@dd37446...c763c91 2024-10-19 jonahwilliams@google.com [Impeller] batch submit vulkan command buffers on newer hardware. (flutter/engine#55956) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…utter/engine#55956) Coming back to this from the previous attempt: flutter/engine#50139 * Even if its slower sometimes, its also way faster on more complex scenes * The adreno bugs seem limited to older devices. Conservatively, only enable batching for Mali and newer Adreno On non vulkan backend we immediately submit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming back to this from the previous attempt: #50139
Conservatively, only enable batching for Mali and newer Adreno
On non vulkan backend we immediately submit.