Switch some mac_unopt tests from intel to arm hosts #55882
Conversation
zanderso
force-pushed
the
zanderso-patch-5
branch
from
a76b44d to
fb48108
Compare
testing/run_tests.py
Outdated
| @@ -505,7 +505,8 @@ def make_test(name, flags=None, extra_env=None): | |||
| # flutter_desktop_darwin_unittests uses global state that isn't handled | |||
| # correctly by gtest-parallel. | |||
| # https://github.com/flutter/flutter/issues/104789 | |||
| if not os.path.basename(build_dir).startswith('host_debug'): | |||
| variant = os.path.basename(build_dir) | |||
| if not variant.startswith('host_debug') and 'arm64' not in variant: | |||
| # Test is disabled for flaking in debug runs: | |||
| # https://github.com/flutter/flutter/issues/127441 | |||
| run_engine_executable( | |||
There was a problem hiding this comment.
So these are effectively not run by CI anymore right?
There was a problem hiding this comment.
Yup. I don't have time to do this, but the right thing to do would be to split off the desktop unit tests to continue running on an intel machine.
There was a problem hiding this comment.
Or make them run on arm64. Is there an issue for why they can't run on arm64?
There was a problem hiding this comment.
I ran them locally on an arm64 machine in debug builds (without gtest-parallel) 5 times and they seem to work.
There was a problem hiding this comment.
I reproduced the error by forking this PR (weird the old result wasn't still available): flutter/flutter#157205
There was a problem hiding this comment.
I have a fix in review for these tests: #55990
There was a problem hiding this comment.
@gaaclarke I see that PR landed. Is it possible to remove one or both of these guards now?
There was a problem hiding this comment.
@zanderso It passed, you are good to rip out that change to run_tests.py
There are about equal numbers. It might create a bottleneck, but I suspect that long queue times are a better trade-off than flaky tests. |
zanderso
force-pushed
the
zanderso-patch-5
branch
from
c64731e to
902b6f3
Compare
|
I'm going to shift this to a draft while some internal retries are investigated. |
zanderso
force-pushed
the
zanderso-patch-5
branch
from
902b6f3 to
43d6d75
Compare
chinmaygarde
added
the
autosubmit
…157751) flutter/engine@70671ba...ed587dc 2024-10-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 69b50768d733 to c9180e9de9e8 (1 revision) (flutter/engine#56180) 2024-10-28 jonahwilliams@google.com [Impeller] fix initial layout for loadOp load and incorrect usage of host visible textures. (flutter/engine#56148) 2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from 21035cd95b68 to bdd225968dab (1 revision) (flutter/engine#56178) 2024-10-28 chris@bracken.jp iOS/macOS: migrate darwin/common to ARC (flutter/engine#56155) 2024-10-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pin local_engine mac builds to arm64 (#56172)" (flutter/engine#56179) 2024-10-28 chris@bracken.jp Migrate PlatformViewIOS to ARC (flutter/engine#55672) 2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from 35ad4e89212f to 21035cd95b68 (1 revision) (flutter/engine#56176) 2024-10-28 aam@google.com Roll buildroot to pick up revert of debugging gen_snapshot prints (flutter/engine#56175) 2024-10-28 zanderso@users.noreply.github.com Pin local_engine mac builds to arm64 (flutter/engine#56172) 2024-10-28 zanderso@users.noreply.github.com Switch some mac_unopt tests from intel to arm hosts (flutter/engine#55882) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
No description provided.