This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor multi-file build parsing into a single BuildPlan class.
#55720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmccutchan
approved these changes
Oct 8, 2024
Contributor
johnmccutchan
left a comment
johnmccutchan
left a comment
There was a problem hiding this comment.
This is a nice cleanup
| import 'environment.dart'; | ||
| import 'logger.dart'; | ||
|
|
||
| const _flagConfig = 'config'; |
Contributor
There was a problem hiding this comment.
Why are we pulling flags out of flags.dart?
Contributor
Author
There was a problem hiding this comment.
They are no longer visible or relevant to the commands (they are implementation details).
Contributor
Author
There was a problem hiding this comment.
That is, the reason we had them in a common place no longer applies.
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2024
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 9, 2024
…156478) flutter/engine@db0c0b7...4a97943 2024-10-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TlU-It6X_ZLrNqMjW... to xGr5ZkxX3CajAY1xu... (flutter/engine#55770) 2024-10-09 skia-flutter-autoroll@skia.org Roll Skia from a077e78e531f to e0bb55353b27 (3 revisions) (flutter/engine#55768) 2024-10-09 chinmaygarde@google.com [Impeller] libImpeller: Allow fetching OpenGL texture handle. (flutter/engine#55753) 2024-10-09 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from jCde9sMKJ3YAdG2DH... to _fkA2GjLQH4bc_n2p... (flutter/engine#55762) 2024-10-09 skia-flutter-autoroll@skia.org Roll Skia from 701b6e4b4bc4 to a077e78e531f (3 revisions) (flutter/engine#55761) 2024-10-09 matanlurey@users.noreply.github.com Release`onTrimMemoryListener` after `ImageReaderSurfaceProducer` released. (flutter/engine#55760) 2024-10-09 bdero@google.com [Flutter GPU] Get the GLES backend/Windows working. (flutter/engine#55694) 2024-10-08 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix incorrect clipping with Opacity scene layer (flutter/engine#55751) 2024-10-08 matanlurey@users.noreply.github.com Refactor multi-file build parsing into a single `BuildPlan` class. (flutter/engine#55720) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from TlU-It6X_ZLr to xGr5ZkxX3Caj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…lutter/engine#55720) Closes flutter#148444 (code de-duplicated). Closes flutter#150877 (`--build-strategy=local`). Closes flutter#150884 (`--build-strategy=remote`). Replaces duplicate code across ~3 commands (query, test, build) with a class called `BuildPlan`, which encapsulates (a) concurrency, (b) build configuration, (c) RBE, (d) LTO, and (e) build strategy. I also moved all of the validation of the build plan into `build_plan_test`, which gives us better coverage at a lower cost (less things to think about in that suite of tests). I know the diff looks scary, but 1K of the 1.4K is tests. /cc @gaaclarke @flar
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#148444 (code de-duplicated).
Closes flutter/flutter#150877 (
--build-strategy=local).Closes flutter/flutter#150884 (
--build-strategy=remote).Replaces duplicate code across ~3 commands (query, test, build) with a class called
BuildPlan, which encapsulates (a) concurrency, (b) build configuration, (c) RBE, (d) LTO, and (e) build strategy. I also moved all of the validation of the build plan intobuild_plan_test, which gives us better coverage at a lower cost (less things to think about in that suite of tests).I know the diff looks scary, but 1K of the 1.4K is tests.
/cc @gaaclarke @flar