Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

iOS: Migrate FlutterEngine to ARC #55590

Merged
merged 31 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f648cce
iOS: Migrate FlutterEngine to ARC
cbracken Oct 2, 2024
d7af9ab
Migrate _dartProject to property
cbracken Oct 3, 2024
9c8140c
Migrate _labelPrefix to property
cbracken Oct 3, 2024
bfbd8ae
Migrate _platformPlugin to a property
cbracken Oct 3, 2024
6e39593
Migrate _textInputPlugin to property
cbracken Oct 3, 2024
708ef4c
Migrate _undoManagerPlugin to property
cbracken Oct 3, 2024
9ede541
Add TODO to use weakSelf
cbracken Oct 3, 2024
4d80478
Migrate _spellCheckPlugin to property
cbracken Oct 3, 2024
8c67e32
Migrate _restorationPlugin to property
cbracken Oct 3, 2024
582b846
Migrate _localizationChannel to property
cbracken Oct 3, 2024
6d44d05
Migrate _navigationChannel to property
cbracken Oct 3, 2024
cde9792
Migrate _restorationChannel to property
cbracken Oct 3, 2024
59a5666
Migrate _platformChannel to property
cbracken Oct 3, 2024
4fb023b
Migrate _platformViewChannel to property
cbracken Oct 3, 2024
0cfd5dd
Migrate _textInputChannel to property
cbracken Oct 3, 2024
30be228
Migrate _undoManagerChannel to property
cbracken Oct 3, 2024
c87e1fc
Migrate _scribbleChannel to property
cbracken Oct 3, 2024
4beaff5
Migrate _spellCheckChannel to property
cbracken Oct 3, 2024
3ff898c
Migrate _lifecycleChannel to property
cbracken Oct 3, 2024
9cb6ca2
Migrate _systemChannel to property
cbracken Oct 3, 2024
a25f67d
Migrate _settingsChannel to property
cbracken Oct 3, 2024
3bbdc73
Migrate _keyEventChannel to property
cbracken Oct 3, 2024
67e50cc
Migrate _screenshotChannel to property
cbracken Oct 3, 2024
f93f238
Migrate _publisher to property
cbracken Oct 3, 2024
dab2366
Migrate _nextTextureId, _allowHeadlessExecution, _restorationEnabled …
cbracken Oct 3, 2024
1542c3f
Add TODO to migrate _viewController
cbracken Oct 3, 2024
f676742
format
cbracken Oct 3, 2024
66923dd
Use weakSelf for handleMethodCall on plugins
cbracken Oct 4, 2024
0ac6fa1
copy labelPrefix
cbracken Oct 4, 2024
ac5e0c2
Review feedback
cbracken Oct 4, 2024
d93d56e
Reformat
cbracken Oct 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell/platform/darwin/ios/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ source_set("flutter_framework_source_arc") {
"framework/Source/FlutterDartVMServicePublisher.mm",
"framework/Source/FlutterEmbedderKeyResponder.h",
"framework/Source/FlutterEmbedderKeyResponder.mm",
"framework/Source/FlutterEngine.mm",
"framework/Source/FlutterEngineGroup.mm",
"framework/Source/FlutterEngine_Internal.h",
"framework/Source/FlutterHeadlessDartRunner.mm",
"framework/Source/FlutterKeyPrimaryResponder.h",
"framework/Source/FlutterKeySecondaryResponder.h",
Expand Down Expand Up @@ -186,8 +188,6 @@ source_set("flutter_framework_source") {
# iOS embedder is migrating to ARC.
# New files are highly encouraged to be in ARC.
# To add new files in ARC, add them to the `flutter_framework_source_arc` target.
"framework/Source/FlutterEngine.mm",
"framework/Source/FlutterEngine_Internal.h",
"framework/Source/FlutterViewController.mm",
"framework/Source/FlutterViewController_Internal.h",
"platform_view_ios.h",
Expand Down
Loading