This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[canvaskit] Further improve overlay optimization by splitting pictures" #55401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… picture…" This reverts commit 8682e51.
yjbanov
approved these changes
Sep 24, 2024
harryterkelsen
added
the
autosubmit
harryterkelsen
deleted the
revert-54878-canvaskit-overlay-split-pictures
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2024
… splitting pictures" (flutter/engine#55401)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 24, 2024
…155629) flutter/engine@7cd3d0b...559f2ff 2024-09-24 1961493+harryterkelsen@users.noreply.github.com Revert "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55401) 2024-09-24 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Further improve overlay optimization by splitting pictures (flutter/engine#54878) 2024-09-24 jonahwilliams@google.com [Impeller] fix OES texture usage. (flutter/engine#55331) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155629) flutter/engine@7cd3d0b...559f2ff 2024-09-24 1961493+harryterkelsen@users.noreply.github.com Revert "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55401) 2024-09-24 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Further improve overlay optimization by splitting pictures (flutter/engine#54878) 2024-09-24 jonahwilliams@google.com [Impeller] fix OES texture usage. (flutter/engine#55331) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155629) flutter/engine@7cd3d0b...559f2ff 2024-09-24 1961493+harryterkelsen@users.noreply.github.com Revert "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55401) 2024-09-24 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Further improve overlay optimization by splitting pictures (flutter/engine#54878) 2024-09-24 jonahwilliams@google.com [Impeller] fix OES texture usage. (flutter/engine#55331) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155629) flutter/engine@7cd3d0b...559f2ff 2024-09-24 1961493+harryterkelsen@users.noreply.github.com Revert "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55401) 2024-09-24 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Further improve overlay optimization by splitting pictures (flutter/engine#54878) 2024-09-24 jonahwilliams@google.com [Impeller] fix OES texture usage. (flutter/engine#55331) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155629) flutter/engine@7cd3d0b...559f2ff 2024-09-24 1961493+harryterkelsen@users.noreply.github.com Revert "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55401) 2024-09-24 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Further improve overlay optimization by splitting pictures (flutter/engine#54878) 2024-09-24 jonahwilliams@google.com [Impeller] fix OES texture usage. (flutter/engine#55331) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #54878
Crashes on real example app with many platform views