Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adds tools/json_injector #55309

Closed
wants to merge 22 commits into from
Closed

Adds tools/json_injector #55309

wants to merge 22 commits into from

Conversation

gaaclarke
Copy link
Member

This adds a tool that will help reduce redundancy in //engine.code-workspace introduced in #55291. It does it by merging json files and applying templates.

I've introduced a tool that can merge json files instead of one that can just do templates since this will keep the source of truth in //engine.code-workspace. I don't think there is a way we can modify vscode to expand templates there.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke
Copy link
Member Author

closing in favor of #55322

@gaaclarke gaaclarke closed this Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant