This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Flutter GPU] Add setStencilReference to RenderPass. #55270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2024
chinmaygarde
approved these changes
Sep 23, 2024
| } | ||
|
|
||
| void setStencilReference(int referenceValue) { | ||
| if (referenceValue < 0 || referenceValue > 0xFFFFFFFF) { |
Member
There was a problem hiding this comment.
Should this be in an assert? Not sure what the design philosophy is for validations in Flutter GPU.
Member
Author
There was a problem hiding this comment.
Hmm yeah... I agree stuff like this aught to be enforced with asserts instead. I'll go through and fix it everywhere as part of flutter/flutter#143891.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 24, 2024
…155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 taskiranmahmutt@gmail.com Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 bdero@google.com [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 jonahwilliams@google.com [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Also adds a golden that depends on #55270. Resolves flutter/flutter#142731. Allow setting the stencil compare function, pass/fail operations, and read/write masks. Flutter GPU has light "shader object" style programs, so all of the stencil configuration state can be set on the `RenderPass` at any time. New simple golden that exercises stencil ops: 
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 taskiranmahmutt@gmail.com Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 bdero@google.com [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 jonahwilliams@google.com [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 taskiranmahmutt@gmail.com Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 bdero@google.com [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 jonahwilliams@google.com [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 taskiranmahmutt@gmail.com Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 bdero@google.com [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 jonahwilliams@google.com [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 taskiranmahmutt@gmail.com Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 bdero@google.com [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 jonahwilliams@google.com [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#142731.
We're missing the pipeline stencil state as well. Will add in a follow-up.