This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix keyboard not showing up when iOS input has decoration text #55152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Sep 12, 2024
yjbanov
reviewed
Sep 12, 2024
| // This is so that the platform views are not obscured by semantic elements | ||
| // and can be reached by inspecting the web page. | ||
| if (!hasChildren && !isPlatformView) { | ||
| if (semanticRole!.acceptsPointerEvents) { |
Contributor
There was a problem hiding this comment.
I'm wondering if we should also check _rect.isEmpty. Although, I can't imagine the framework merging a tappable node such that the merged result is empty. So maybe I'm overthinking this.
Contributor
Author
There was a problem hiding this comment.
You're worried that we may set pointer-events: all on an empty rect? I don't know if this case ever happens or not, but even if it does, I don't see a problem with accepting pointer events on an empty rect that's not going to obscure anything 🙂
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 24, 2024
…155610) flutter/engine@8a54cc5...2745b87 2024-09-24 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove deprecated and unnecessary parameters from fuchsia*archive (flutter/engine#55324) 2024-09-24 mdebbar@google.com [web] Fix keyboard not showing up when iOS input has decoration text (flutter/engine#55152) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155610) flutter/engine@8a54cc5...2745b87 2024-09-24 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove deprecated and unnecessary parameters from fuchsia*archive (flutter/engine#55324) 2024-09-24 mdebbar@google.com [web] Fix keyboard not showing up when iOS input has decoration text (flutter/engine#55152) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155610) flutter/engine@8a54cc5...2745b87 2024-09-24 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove deprecated and unnecessary parameters from fuchsia*archive (flutter/engine#55324) 2024-09-24 mdebbar@google.com [web] Fix keyboard not showing up when iOS input has decoration text (flutter/engine#55152) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155610) flutter/engine@8a54cc5...2745b87 2024-09-24 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove deprecated and unnecessary parameters from fuchsia*archive (flutter/engine#55324) 2024-09-24 mdebbar@google.com [web] Fix keyboard not showing up when iOS input has decoration text (flutter/engine#55152) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155610) flutter/engine@8a54cc5...2745b87 2024-09-24 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove deprecated and unnecessary parameters from fuchsia*archive (flutter/engine#55324) 2024-09-24 mdebbar@google.com [web] Fix keyboard not showing up when iOS input has decoration text (flutter/engine#55152) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations, semantics elements get assigned
pointer-events: nonewhen they aren't supposed to.One such situation is when a text field has a decoration error text. The semantics node become a container, and we always set
pointer-events: noneon container nodes.This PR introduces an
acceptsPointerEventsgetter onSemanticRoleandSemanticBehaviorto control whenpointer-eventsshould beallornone.Fixes flutter/flutter#141975