Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert dart to b81b344a194f #54782

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

flar
Copy link
Contributor

@flar flar commented Aug 26, 2024

A recent Dart SDK change causes some customer repos tested in the framework to get "uninitialized field" errors. Backing off the SDK to before this happened so we can get the repos fixed.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@auto-submit auto-submit bot merged commit f645ca5 into flutter:main Aug 26, 2024
34 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 26, 2024
…sions) (#154137)

Manual roll requested by jimgraham@google.com

flutter/engine@365b0c7...f645ca5

2024-08-26 flar@google.com Revert dart to b81b344a194f (flutter/engine#54782)
2024-08-26 yjbanov@google.com [web] set the "dialog" ARIA role unconditionally (flutter/engine#54761)
2024-08-26 magder@google.com Revert "Test running the macOS engine has no stray logging" (flutter/engine#54778)
2024-08-26 chris@bracken.jp clangd_check: write .clangd as part of test (flutter/engine#54766)
2024-08-26 skia-flutter-autoroll@skia.org Roll Dart SDK from c7eb3230248a to 94c21ec02e28 (2 revisions) (flutter/engine#54776)
2024-08-26 47866232+chunhtai@users.noreply.github.com [Android] Drops semantics query when app is not attached (flutter/engine#52040)
2024-08-26 jonahwilliams@google.com [ui] fix missing color conversion in drawAtlas. (flutter/engine#54750)
2024-08-26 skia-flutter-autoroll@skia.org Roll Skia from ce0656c1d79c to a05dbd2a60f0 (3 revisions) (flutter/engine#54774)
2024-08-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CVnRW3RAZuTq0lVaw... to QqRZlA9wVbeg4WoPz... (flutter/engine#54770)
2024-08-26 jonahwilliams@google.com [Impeller] delete impeller image class. (flutter/engine#54767)
2024-08-25 jonahwilliams@google.com [Impeller] more test migration. (flutter/engine#54763)
2024-08-25 chris@bracken.jp [macOS] Add TODOs to remove AppKit bug workaround (flutter/engine#54764)
2024-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5uR6WvDV5FX-aZgKQ... to CVnRW3RAZuTq0lVaw... (flutter/engine#54765)
2024-08-24 skia-flutter-autoroll@skia.org Roll Skia from d59df6f6f4f3 to ce0656c1d79c (2 revisions) (flutter/engine#54760)
2024-08-24 skia-flutter-autoroll@skia.org Roll Skia from 741972846fa2 to d59df6f6f4f3 (1 revision) (flutter/engine#54758)
2024-08-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0d2McFgsNwG-5r1Rb... to 5uR6WvDV5FX-aZgKQ... (flutter/engine#54757)
2024-08-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 586ba94c96a4 to c7eb3230248a (2 revisions) (flutter/engine#54755)
2024-08-24 skia-flutter-autoroll@skia.org Roll Skia from 0086a17e0d4c to 741972846fa2 (3 revisions) (flutter/engine#54753)
2024-08-24 skia-flutter-autoroll@skia.org Roll Dart SDK from b81b344a194f to 586ba94c96a4 (1 revision) (flutter/engine#54752)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 0d2McFgsNwG- to QqRZlA9wVbeg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…sions) (flutter#154137)

Manual roll requested by jimgraham@google.com

flutter/engine@365b0c7...f645ca5

2024-08-26 flar@google.com Revert dart to b81b344a194f (flutter/engine#54782)
2024-08-26 yjbanov@google.com [web] set the "dialog" ARIA role unconditionally (flutter/engine#54761)
2024-08-26 magder@google.com Revert "Test running the macOS engine has no stray logging" (flutter/engine#54778)
2024-08-26 chris@bracken.jp clangd_check: write .clangd as part of test (flutter/engine#54766)
2024-08-26 skia-flutter-autoroll@skia.org Roll Dart SDK from c7eb3230248a to 94c21ec02e28 (2 revisions) (flutter/engine#54776)
2024-08-26 47866232+chunhtai@users.noreply.github.com [Android] Drops semantics query when app is not attached (flutter/engine#52040)
2024-08-26 jonahwilliams@google.com [ui] fix missing color conversion in drawAtlas. (flutter/engine#54750)
2024-08-26 skia-flutter-autoroll@skia.org Roll Skia from ce0656c1d79c to a05dbd2a60f0 (3 revisions) (flutter/engine#54774)
2024-08-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CVnRW3RAZuTq0lVaw... to QqRZlA9wVbeg4WoPz... (flutter/engine#54770)
2024-08-26 jonahwilliams@google.com [Impeller] delete impeller image class. (flutter/engine#54767)
2024-08-25 jonahwilliams@google.com [Impeller] more test migration. (flutter/engine#54763)
2024-08-25 chris@bracken.jp [macOS] Add TODOs to remove AppKit bug workaround (flutter/engine#54764)
2024-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5uR6WvDV5FX-aZgKQ... to CVnRW3RAZuTq0lVaw... (flutter/engine#54765)
2024-08-24 skia-flutter-autoroll@skia.org Roll Skia from d59df6f6f4f3 to ce0656c1d79c (2 revisions) (flutter/engine#54760)
2024-08-24 skia-flutter-autoroll@skia.org Roll Skia from 741972846fa2 to d59df6f6f4f3 (1 revision) (flutter/engine#54758)
2024-08-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0d2McFgsNwG-5r1Rb... to 5uR6WvDV5FX-aZgKQ... (flutter/engine#54757)
2024-08-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 586ba94c96a4 to c7eb3230248a (2 revisions) (flutter/engine#54755)
2024-08-24 skia-flutter-autoroll@skia.org Roll Skia from 0086a17e0d4c to 741972846fa2 (3 revisions) (flutter/engine#54753)
2024-08-24 skia-flutter-autoroll@skia.org Roll Dart SDK from b81b344a194f to 586ba94c96a4 (1 revision) (flutter/engine#54752)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 0d2McFgsNwG- to QqRZlA9wVbeg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants