This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[engine] Split encode and submit into two different surface frame callbacks. #54200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Jul 29, 2024
| @@ -106,8 +114,17 @@ class SurfaceFrame { | |||
|
|
|||
| sk_sp<DisplayList> BuildDisplayList(); | |||
|
|
|||
| void set_user_data(std::shared_ptr<impeller::Surface> data) { | |||
There was a problem hiding this comment.
This is a little wonky. For the impeller metal gpu surface, we construct the corresponding render target during the encode callback and not before - due to partial repaint - so we need a place to store the shared ptr for the present callback.
chinmaygarde
approved these changes
Jul 30, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 30, 2024
…152583) flutter/engine@a4b88a3...08f9be3 2024-07-30 chris@bracken.jp [iOS] Delete unused create_ios_framework.py (flutter/engine#54227) 2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226) 2024-07-30 jonahwilliams@google.com [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200) 2024-07-30 matej.knopp@gmail.com Do not disable partial repaint based on thread merging state (flutter/engine#54219) 2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152583) flutter/engine@a4b88a3...08f9be3 2024-07-30 chris@bracken.jp [iOS] Delete unused create_ios_framework.py (flutter/engine#54227) 2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226) 2024-07-30 jonahwilliams@google.com [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200) 2024-07-30 matej.knopp@gmail.com Do not disable partial repaint based on thread merging state (flutter/engine#54219) 2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152583) flutter/engine@a4b88a3...08f9be3 2024-07-30 chris@bracken.jp [iOS] Delete unused create_ios_framework.py (flutter/engine#54227) 2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226) 2024-07-30 jonahwilliams@google.com [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200) 2024-07-30 matej.knopp@gmail.com Do not disable partial repaint based on thread merging state (flutter/engine#54219) 2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much easier to implement the deferred submit required for #53826