This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix embedder comments about struct_size #54077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: comment-only change (The bot should have known that, so the Cocoon settings for flutter/engine may be off?) |
cbracken
reviewed
Jul 24, 2024
cbracken
approved these changes
Jul 24, 2024
loic-sharma
approved these changes
Jul 24, 2024
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2024
…152260) flutter/engine@490576d...c2f489d 2024-07-24 robert.ancell@canonical.com Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 jonahwilliams@google.com share platform view slicing logic across iOS and Android. (flutter/engine#54010) 2024-07-24 jacksongardner@google.com [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 2024-07-24 43054281+camsim99@users.noreply.github.com Upgrade Engine Android SDK to 35 (flutter/engine#53574) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152260) flutter/engine@490576d...c2f489d 2024-07-24 robert.ancell@canonical.com Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 jonahwilliams@google.com share platform view slicing logic across iOS and Android. (flutter/engine#54010) 2024-07-24 jacksongardner@google.com [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 2024-07-24 43054281+camsim99@users.noreply.github.com Upgrade Engine Android SDK to 35 (flutter/engine#53574) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152260) flutter/engine@490576d...c2f489d 2024-07-24 robert.ancell@canonical.com Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 jonahwilliams@google.com share platform view slicing logic across iOS and Android. (flutter/engine#54010) 2024-07-24 jacksongardner@google.com [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 2024-07-24 43054281+camsim99@users.noreply.github.com Upgrade Engine Android SDK to 35 (flutter/engine#53574) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.