Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[WIP] expose Semantics.identifier as Windows UIA AutomationId #53729

Closed
wants to merge 5 commits into from

Conversation

nicerloop
Copy link

Expose Semantics.identifier as Windows AutomationId to ease application automation.

see flutter/flutter#148763

replaces #53476

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

I don't know how/where I can add tests for this feature.

CLA signing requires my employer to find/define who will sign.

2 tests fail to pass on Windows, both before and after my modifications:

  • engine\src\out\host_debug_unopt\flutter_windows_unittests.exe KeyboardTest.DeadKeyTwiceThenLetter
  • engine\src\out\host_debug_unopt\flutter_windows_unittests.exe KeyboardTest.DeadKeyWithoutDeadMaskThatCombines

Copy link

google-cla bot commented Jul 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nicerloop; a few points.

  1. It looks like you're missing a CLA. Once you've completed that step, please let us know.
  2. This appears to be causing some of the common_cpp_unittests to fail on macOS. Please fix the test failures.
    Once these items are addressed, please let us know.

@nicerloop nicerloop force-pushed the windows-automationid branch 3 times, most recently from 6807916 to 0e65177 Compare July 12, 2024 11:41
@cbracken
Copy link
Member

Hi @nicerloop thanks for fixing the test failures. Please be aware that we cannot review any patch until we have a signed CLA on file. Let us know once that's done and we'll take a look!

@nicerloop nicerloop changed the title expose Semantics.identifier as Windows UIA AutomationId [WIP] expose Semantics.identifier as Windows UIA AutomationId Jul 12, 2024
@nicerloop nicerloop force-pushed the windows-automationid branch 5 times, most recently from b23ab46 to 4587321 Compare July 18, 2024 01:47
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@cbracken
Copy link
Member

Hi @nicerloop, are you still working on this?

@nicerloop
Copy link
Author

nicerloop commented Aug 16, 2024

Hi,

I am currently on vacation, and I am still waiting for official CLA signature from my employer. The original need remains and I will get back to work on this PR in september.

@loic-sharma
Copy link
Member

@nicerloop Hey there, we can't review this until the CLA is completed. I'll convert this to a draft for now, feel free to change it back once this is ready for review. Thanks for the contribution!

@loic-sharma loic-sharma marked this pull request as draft September 23, 2024 17:10
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@nicerloop nicerloop force-pushed the windows-automationid branch 2 times, most recently from d3438a4 to b48fd45 Compare October 1, 2024 14:28
@nicerloop nicerloop force-pushed the windows-automationid branch 2 times, most recently from 6a5b7f2 to bf57822 Compare October 2, 2024 09:22
@nicerloop nicerloop force-pushed the windows-automationid branch from bf57822 to 1e68f0c Compare October 2, 2024 10:25
@cbracken
Copy link
Member

Since we've had no response on this patch, we're going to close it for now. @nicerloop, once you've got any permissions you need on the CLA side of things, please re-open a new patch and we'll gladly review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants