-
Notifications
You must be signed in to change notification settings - Fork 6k
[WIP] expose Semantics.identifier as Windows UIA AutomationId #53729
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
a388914
to
fb2341b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nicerloop; a few points.
- It looks like you're missing a CLA. Once you've completed that step, please let us know.
- This appears to be causing some of the common_cpp_unittests to fail on macOS. Please fix the test failures.
Once these items are addressed, please let us know.
6807916
to
0e65177
Compare
Hi @nicerloop thanks for fixing the test failures. Please be aware that we cannot review any patch until we have a signed CLA on file. Let us know once that's done and we'll take a look! |
b23ab46
to
4587321
Compare
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
Hi @nicerloop, are you still working on this? |
Hi, I am currently on vacation, and I am still waiting for official CLA signature from my employer. The original need remains and I will get back to work on this PR in september. |
4587321
to
eac7572
Compare
@nicerloop Hey there, we can't review this until the CLA is completed. I'll convert this to a draft for now, feel free to change it back once this is ready for review. Thanks for the contribution! |
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
eac7572
to
5437924
Compare
d3438a4
to
b48fd45
Compare
6a5b7f2
to
bf57822
Compare
…icsNode2::identifier
…Bridge::SemanticsNode::identifier (+1 squashed commit) Squashed commits: [422b23e] fix mac tests
…a::StringAttributes[AuthorUniqueId]
…odeDelegate::AuthorUniqueId
…UniqueId as AutomationId
bf57822
to
1e68f0c
Compare
Since we've had no response on this patch, we're going to close it for now. @nicerloop, once you've got any permissions you need on the CLA side of things, please re-open a new patch and we'll gladly review. |
Expose Semantics.identifier as Windows AutomationId to ease application automation.
see flutter/flutter#148763
replaces #53476
Pre-launch Checklist
///
).I don't know how/where I can add tests for this feature.
CLA signing requires my employer to find/define who will sign.
2 tests fail to pass on Windows, both before and after my modifications: