This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Use Skia software renderer to draw stroked text. #53198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
added 2 commits
June 5, 2024 10:13
|
Golden file changes are available for triage from new commit, Click here to view. |
Contributor
Author
|
FYI @chinmaygarde |
chinmaygarde
approved these changes
Jun 5, 2024
jonahwilliams
added
the
autosubmit
jonahwilliams
added
the
revert
Contributor
Author
|
reason for revert: oops. |
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jun 6, 2024
…53198)" (#53237) Reverts: #53198 Initiated by: jonahwilliams Reason for reverting: oops. Original PR Author: jonahwilliams Reviewed By: {chinmaygarde} This change reverts the following previous change: We need to match the rounding of glyphs to fix flutter/flutter#138670 . We also don't have sufficient AA quality with 4x MSAA for high quality strokes. Fixes flutter/flutter#138670 Fixes flutter/flutter#136688
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2024
…149785) flutter/engine@f51e0ad...0edca2e 2024-06-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Use Skia software renderer to draw stroked text. (#53198)" (flutter/engine#53237) 2024-06-05 jonahwilliams@google.com [Impeller] Use Skia software renderer to draw stroked text. (flutter/engine#53198) 2024-06-05 chinmaygarde@google.com Remove the DBC interpreter flag. (flutter/engine#53204) 2024-06-05 ditman@gmail.com [web] Adds allowPlatformDefault for wheel signals. (flutter/engine#51566) 2024-06-05 jonahwilliams@google.com [Impeller] fix emojis with non-solid color sources. (flutter/engine#53229) 2024-06-05 skia-flutter-autoroll@skia.org Roll Skia from 8448abc95867 to 89570a0a171e (1 revision) (flutter/engine#53236) 2024-06-05 skia-flutter-autoroll@skia.org Roll Dart SDK from f838a9a8d45f to 86b8aacb2609 (1 revision) (flutter/engine#53234) 2024-06-05 flar@google.com [DisplayList] remove legacy DisplayListMatrixClipTracker (flutter/engine#53232) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to match the rounding of glyphs to fix flutter/flutter#138670 . We also don't have sufficient AA quality with 4x MSAA for high quality strokes.
Fixes flutter/flutter#138670
Fixes flutter/flutter#136688