Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Google java format relocation and formatting update #53118

Merged

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented May 30, 2024

Fixes flutter/flutter#149319
Caused by #52582

Follow up required to add a flag that fails on missing jar files instead of skipping missing jar files.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2024
@auto-submit auto-submit bot merged commit 4645927 into flutter:main May 31, 2024
31 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 31, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 31, 2024
…149447)

flutter/engine@fa30658...1814031

2024-05-31 lhkbob@gmail.com Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE flag (flutter/engine#49563)
2024-05-31 jonahwilliams@google.com Remove complexity calculator with Slimpeller (flutter/engine#53140)
2024-05-31 skia-flutter-autoroll@skia.org Roll Skia from 208469d270b7 to f1f13534b0c2 (1 revision) (flutter/engine#53152)
2024-05-31 skia-flutter-autoroll@skia.org Roll Skia from ce975ddfd9fb to 208469d270b7 (1 revision) (flutter/engine#53150)
2024-05-31 reidbaker@google.com Google java format relocation and formatting update  (flutter/engine#53118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker deleted the reidbaker-google-java-format-relocation branch June 3, 2024 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cherry picks to the engine require formatting
2 participants