This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Refactor impeller.gni #52942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
May 20, 2024
| # Whether to use a prebuilt impellerc. | ||
| # If this is the empty string, impellerc will be built. | ||
| # If it is non-empty, it should be the absolute path to impellerc. | ||
| impeller_use_prebuilt_impellerc = "" |
There was a problem hiding this comment.
This option is no longer being used since migrating to the engine_v2 recipes. Using it in the engine_v2 recipes would be difficult. If you're up for it, it can be safely deleted.
There was a problem hiding this comment.
Wilco in a followup. Is this also the case for impeller_use_prebuilt_scenec?
| flutter_runtime_mode == "debug" || flutter_runtime_mode == "profile" | ||
|
|
||
| # Whether the runtime capture/playback system is enabled. | ||
| impeller_capture = flutter_runtime_mode == "debug" |
There was a problem hiding this comment.
This is unused post #52932
| impeller_enable_3d = false | ||
|
|
||
| # Enable to get trace statements for canvas usage. | ||
| impeller_trace_canvas = false |
|
I'm going to land just this refactor on its own and remove the unused stuff in a followup as there are already conflicts removing the canvas flags. |
impeller.gni turned from a small include file with minor templates into a giant 1000 line mess of unrelated templates over time. Moves templates into their own "TU"s. Once this patch sticks, will document all the templates and flags. No change in functionality in this patch. Just moves templates around.
chinmaygarde
force-pushed
the
refactor_impeller_gni
branch
from
2ea8c5c to
b8249ce
Compare
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 21, 2024
…148802) flutter/engine@a8872c8...bc1345b 2024-05-21 chinmaygarde@google.com [Impeller] Remove unused GN flags. (flutter/engine#52962) 2024-05-21 30870216+gaaclarke@users.noreply.github.com Reland `Fixes MatrixFilterContents rendering/coverage #52880` (flutter/engine#52939) 2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from dd768e0d1890 to f0ac30bbc63e (1 revision) (flutter/engine#52958) 2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 4f6568ba7051 to df78435c2f26 (4 revisions) (flutter/engine#52959) 2024-05-21 chinmaygarde@google.com [Impeller] Refactor impeller.gni (flutter/engine#52942) 2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from ca98796cc19e to 4f6568ba7051 (2 revisions) (flutter/engine#52956) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impeller.gniturned from a small include file with minor templates into a giant 1000 line mess of unrelated templates over time.Moves templates into their own "TU"s. Once this patch sticks, will document all the templates and flags. No change in functionality in this patch. Just moves templates around.