Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove default for stripped option, don't strip by default on android #52852

Closed
wants to merge 13 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tools/gn
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,12 @@ def to_gn_args(args):
if args.build_embedder_examples is not None:
gn_args['build_embedder_examples'] = args.build_embedder_examples

gn_args['stripped_symbols'] = args.stripped
if args.stripped is True:
gn_args['stripped_symbols'] = True
elif args.stripped is False:
gn_args['stripped_symbols'] = False
else:
gn_args['stripped_symbols'] = args.target_os != 'android'

if args.msan:
gn_args['is_msan'] = True
Expand Down Expand Up @@ -1113,7 +1118,6 @@ def parse_args(args):

parser.add_argument(
'--stripped',
default=True,
action='store_true',
help='Strip debug symbols from the output. This defaults to true and has no effect on iOS.'
)
Expand Down
Loading