This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Roll Dart SDK from b7cad2edae4b to 673b3aa8558a (1 revision) (#52677)" #52683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
May 8, 2024
auto-submit
bot
deleted the
revert_86d2768e0f79a5df78885163b17717ec4000c4a7
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 8, 2024
…148010) flutter/engine@9cb60de...93c5040 2024-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from b7cad2edae4b to 673b3aa8558a (1 revision) (#52677)" (flutter/engine#52683) 2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from d965fc1fd319 to 4019d8957cff (2 revisions) (flutter/engine#52682) 2024-05-08 30870216+gaaclarke@users.noreply.github.com Revert 484688634c71ec38c18218eaa13dc47fa7007b74 (flutter/engine#52680) 2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from d8427844b843 to d965fc1fd319 (4 revisions) (flutter/engine#52679) 2024-05-08 jonahwilliams@google.com [Impeller] require and use backpressure for AHB swapchain. (flutter/engine#52676) 2024-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from b7cad2edae4b to 673b3aa8558a (1 revision) (flutter/engine#52677) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #52677
Initiated by: zanderso
Reason for reverting: Failed roll to framework in flutter/flutter#147999
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/b7cad2edae4b..673b3aa8558a
2024-05-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-139.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md