This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll reclient forward #52632
Merged
Roll reclient forward #52632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
commented
May 8, 2024
DEPS
Outdated
| @@ -277,7 +277,7 @@ allowed_hosts = [ | |||
| ] | |||
|
|
|||
| deps = { | |||
| 'src': 'https://github.com/flutter/buildroot.git' + '@' + 'c5f0206b6fd70a85a41718f0bc6481b7c5348026', | |||
| 'src': 'https://github.com/zanderso/buildroot.git' + '@' + '158dbfbc4f5fa8606776218b32c75be706afb394', | |||
There was a problem hiding this comment.
Will fix when buildroot patch lands.
jason-simmons
approved these changes
May 8, 2024
This was referenced May 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 8, 2024
…147994) flutter/engine@f3ce5a5...9cb60de 2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from c7794fee8063 to d8427844b843 (2 revisions) (flutter/engine#52671) 2024-05-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from a9cf6a411c71 to b7cad2edae4b (7 revisions) (flutter/engine#52669) 2024-05-08 jonahwilliams@google.com [Impeller] Update BlitPass::AddCopy to use destination_region instead of origin for buffer to texture copies. (flutter/engine#52555) 2024-05-08 flar@google.com DisplayListBuilder internal reorganization with better rendering op overlap detection (flutter/engine#52646) 2024-05-08 zanderso@users.noreply.github.com Roll reclient forward (flutter/engine#52632) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#147750.
Depends on flutter/buildroot#852.
This PR rolls forward reclient, the buildroot, and our RBE configs. The new RBE configs do a few things. First they default the exec strategy to
racing. Second, they add a local wrapper script that passes the correct value for-fdebug-prefix-mapin both the local and remote cases. Finally, they remove the canonicalization of the build's working directory, so that the remote working directory will have the same name as the local working directory. This solves the issue where the build working directory contained a mysteriousset_by_reclient/acomponent.