This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Wait for the previous AHB texture to be fully recyclable. #52588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still WIP as I am not able to explain a validation error on early semaphore destruction. But it may be that I am doing something wrong where the tracked objects are being collected too early. |
|
Oh, missed your comment here. i will check this out and play around with it for a bit, I have a few ideas. |
|
Ok, the validation errors due to bad tracking are now fixed. Need to verify the waits actually fix our original issue (they should) and also patchup the tracing in the present ready fence case as I believe I made the same mistake earlier. |
The Android surface transaction completion handler documentation states: ``` Buffers which are replaced or removed from the scene in the transaction invoking this callback may be reused after this point. ``` However, this is NOT sufficient. One also needs to be obtain the previous release fence and perform a wait for the buffer to be safely reusable. This patch adds a GPU side wait for this fence using available extensions.
chinmaygarde
force-pushed
the
render_ready_wait
branch
from
7660737 to
ca99a7c
Compare
|
Experimenting with the macrobenchmarks app, I couldn't see the checkerboarding we saw last week. I think this is good to go. |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 7, 2024
…147939) flutter/engine@d88b7db...42898e0 2024-05-07 chinmaygarde@google.com [Impeller] Wait for the previous AHB texture to be fully recyclable. (flutter/engine#52588) 2024-05-07 jason-simmons@users.noreply.github.com Manual Skia roll to 2319f1ae8fe42525f8b6a1969a1cee67bdbee290 (flutter/engine#52615) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android surface transaction completion handler documentation states:
However, this is NOT sufficient. One also needs to be obtain the previous release fence and perform a wait for the buffer to be safely reusable.
This patch adds a GPU side wait for this fence using available extensions.
Fixes flutter/flutter#147758