-
Notifications
You must be signed in to change notification settings - Fork 6k
Set deep linking flag to true by default #52350
Changes from all commits
0be4fe7
4653527
4a05924
96e87e3
8ea2d1b
8f1b9c5
eb0a4ef
5a1ddc6
318ab25
740ffa9
7c09085
c22082d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,9 +16,9 @@ | |
import static io.flutter.embedding.android.FlutterActivityLaunchConfigs.EXTRA_DART_ENTRYPOINT_ARGS; | ||
import static io.flutter.embedding.android.FlutterActivityLaunchConfigs.EXTRA_DESTROY_ENGINE_WITH_ACTIVITY; | ||
import static io.flutter.embedding.android.FlutterActivityLaunchConfigs.EXTRA_INITIAL_ROUTE; | ||
import static io.flutter.embedding.android.FlutterActivityLaunchConfigs.HANDLE_DEEPLINKING_META_DATA_KEY; | ||
import static io.flutter.embedding.android.FlutterActivityLaunchConfigs.INITIAL_ROUTE_META_DATA_KEY; | ||
import static io.flutter.embedding.android.FlutterActivityLaunchConfigs.NORMAL_THEME_META_DATA_KEY; | ||
import static io.flutter.embedding.android.FlutterActivityLaunchConfigs.deepLinkEnabled; | ||
|
||
import android.content.Context; | ||
import android.content.Intent; | ||
|
@@ -695,9 +695,7 @@ protected boolean shouldAttachEngineToActivity() { | |
protected boolean shouldHandleDeeplinking() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this code go into a shared location since it is identical? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see there half of the functions in FlutterActivity.java and FlutterFragmentActivity.java are identical, so I was just following the pattern. Maybe FlutterActivity and FlutterFragmentActivity need a refactor to move all identical code into a shared location? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I still think this code should not be duplicated There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's fair, i moved shared code into [FlutterActivityLaunchConfigs.java] |
||
try { | ||
Bundle metaData = getMetaData(); | ||
boolean shouldHandleDeeplinking = | ||
metaData != null ? metaData.getBoolean(HANDLE_DEEPLINKING_META_DATA_KEY) : false; | ||
return shouldHandleDeeplinking; | ||
return deepLinkEnabled(metaData); | ||
} catch (PackageManager.NameNotFoundException e) { | ||
return false; | ||
} | ||
|
Uh oh!
There was an error while loading. Please reload this page.