Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] add test case for path that explicitly closes at origin. #52314

Merged
merged 1 commit into from
Apr 23, 2024
Merged

[Impeller] add test case for path that explicitly closes at origin. #52314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions impeller/geometry/path_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,22 @@ TEST(PathTest, CloseAfterMoveDoesNotAddNewLines) {
EXPECT_EQ(path.GetComponentCount(Path::ComponentType::kContour), 2u);
}

TEST(PathTest, CloseAtOriginDoesNotAddNewLineSegment) {
PathBuilder builder;
// Create a path that has a current position at the origin when close is
// called. This should not insert a new line segment
auto path = builder.LineTo({10, 0})
.LineTo({10, 10})
.LineTo({0, 10})
.LineTo({0, 0})
.Close()
.TakePath();

EXPECT_EQ(path.GetComponentCount(), 6u);
EXPECT_EQ(path.GetComponentCount(Path::ComponentType::kLinear), 4u);
EXPECT_EQ(path.GetComponentCount(Path::ComponentType::kContour), 2u);
}

TEST(PathTest, CanBeCloned) {
PathBuilder builder;
builder.MoveTo({10, 10});
Expand Down