This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP][Impeller] Enable logging a warning when the user opts out of using Impeller. (#51849) #51914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpeller. (flutter#51849) Part of flutter/flutter#144439 This does two things: * Logs a warning when the embedder requests a non-Impeller preference when creating a shell. * Makes the iOS embedder request a warning be logged when Impeller is not used. I decided to put the warning logs in the shell so that as we get more opinionated about Impeller on other platforms, those platforms can just flip a flag with common log origin.
|
Filing this CP request per the guidance in #51849 (comment). |
chinmaygarde
added
the
cp: review
XilaiZhang
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
might be good to also file a separate cherry pick issue to be formally included in a release
|
@XilaiZhang Done! |
godofredoc
added
the
autosubmit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#144439
This does two things:
I decided to put the warning logs in the shell so that as we get more opinionated about Impeller on other platforms, those platforms can just flip a flag with common log origin.