Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move scenario_app integration tests back to max_attempts: 2. #51838

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

matanlurey
Copy link
Contributor

This seems to be the flakiest target, and is/was making our CI red all day.

Related: flutter/flutter#145988.

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Apr 2, 2024
@auto-submit auto-submit bot merged commit 370e325 into flutter:main Apr 2, 2024
@matanlurey matanlurey deleted the emulator-skia-max-attempts-2 branch April 2, 2024 01:06
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 2, 2024
…146109)

flutter/engine@9a513de...370e325

2024-04-02 matanlurey@users.noreply.github.com Move scenario_app integration tests back to `max_attempts: 2`. (flutter/engine#51838)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants