This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[web] Adds allowPlatformDefault for wheel signals. #51566
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c9f1c87
Prototype of handled datapacket.
ditman a9aa5a0
Revert "Prototype of handled datapacket."
ditman c07cd07
Add acknowledgePointerDataPacket method.
ditman 38dc67d
Revert "Add acknowledgePointerDataPacket method."
ditman 8a52806
Adds configurable `respond` method to PointerData.
ditman a2514a6
Add allowPlatformDefault to PointerData class.
ditman 18356f6
Update dart:ui PointerData with the respond function.
ditman 3407515
Add unit tests.
ditman 4d843f0
Update lib/web_ui/lib/src/engine/pointer_binding.dart
ditman aab6edc
Remove unnecessary abbreviation of event to e
ditman c5ae325
Apply suggestions from code review
ditman 3ec123e
Some more PR suggestions.
ditman 6f60cce
OnPointerDataRespondCallback -> PointerDataRespondCallback
ditman 9bc8123
Fix api_conform_test so it understands named parameters in typedefs.
ditman 663dafa
Add info on what happens when NOT calling the method.
ditman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can inline a function type here without creating a one-off
typedef. Is this a guideline or something?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevmoo I went back and forth on this (I originally had this as an inline function type). The Style guide for Flutter repo that @goderbauer linked says this:
I don't have strong feelings about it (but when we were bikeshedding in parameter name, it was a chore to rename it in several, unconnected parts, and that's when I ended up adding the
typedef... it's also nice to be able to add some dartdoc to the typedef).