Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "[Fuchsia] only download fuchsia deps when necessary (#51439)" #51508

Conversation

zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Mar 19, 2024

Reverts #51500 and relands #51439 with the default download_fuchsia_deps unchanged and enabled via host_os == "linux".

Something not mentioned in the previous change description, since the engine_v2 recipe now supports gclient_variables forwarding, I moved the duplicated download_android_deps: False into the .ci.yaml, i.e. the root builder from the drone ci/builders/linux_fuchsia.json file.

Original change description:

This is a quick follow up of #51072 to only download fuchsia deps (via download_fuchsia_deps gclient arg) when necessary. Considering the pr/51072 is very huge, keeping these condition changes in a separate change would be cleaner.

The wiki has been updated already since setting the download_fuchsia_deps gclient arg explicitly won't break the existing workflow. I also mentioned in the wiki that building and running fuchsia needed a linux box (an explicit assertion in the with_envs.py).

Bug: http://b/40935282

@zijiehe-google-com zijiehe-google-com marked this pull request as ready for review March 19, 2024 16:55
@zijiehe-google-com zijiehe-google-com marked this pull request as draft March 19, 2024 20:41
@zijiehe-google-com
Copy link
Contributor Author

zijiehe-google-com commented Mar 19, 2024

A little bit struggling to demonstrate the importance of this change; keep it as a draft for now.

The only benefit of this change is to avoid downloading images in two of eight drone builders which was unfortunately caused by a typo in the original change.

@jtmcdole
Copy link
Member

(triage): reached out to author for more feedback

@zijiehe-google-com
Copy link
Contributor Author

Thank you for reaching out. As mentioned in #51508 (comment), this change isn't important enough to merge.

@zijiehe-google-com zijiehe-google-com deleted the revert-51500-revert_9162c8309e247be465bb4fa7173f704c2053b9b3 branch October 22, 2024 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants