This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "[Fuchsia] only download fuchsia deps when necessary (#51439)" #51508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #51500 and relands #51439 with the default
download_fuchsia_deps
unchanged and enabled viahost_os == "linux"
.Something not mentioned in the previous change description, since the engine_v2 recipe now supports
gclient_variables
forwarding, I moved the duplicateddownload_android_deps: False
into the.ci.yaml
, i.e. the root builder from the droneci/builders/linux_fuchsia.json
file.Original change description:
This is a quick follow up of #51072 to only download fuchsia deps (via download_fuchsia_deps gclient arg) when necessary. Considering the pr/51072 is very huge, keeping these condition changes in a separate change would be cleaner.
The wiki has been updated already since setting the download_fuchsia_deps gclient arg explicitly won't break the existing workflow. I also mentioned in the wiki that building and running fuchsia needed a linux box (an explicit assertion in the with_envs.py).
Bug: http://b/40935282