This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reduce code-duplication a bit and add more error context across SkiaGoldClient.
#51426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Mar 14, 2024
| import 'package:path/path.dart' as path; | ||
| import 'package:process/process.dart'; | ||
|
|
||
| import 'src/errors.dart'; |
Member
There was a problem hiding this comment.
Should these uri's have the package in them instead of being relative paths?
Contributor
Author
There was a problem hiding this comment.
I don't feel strongly either way (would prefer a lint).
It appears we're intentionally opting out. I'll file a follow-up issue to suggest opting back in?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2024
…ross `SkiaGoldClient`. (flutter/engine#51426)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 15, 2024
…145191) flutter/engine@622b372...995d890 2024-03-14 matanlurey@users.noreply.github.com Add some header-goodies for et. (flutter/engine#51434) 2024-03-14 jonahwilliams@google.com [Impeller] revert glyph atlas texture recycling. (flutter/engine#51428) 2024-03-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add DisplayList Region and Transform benchmarks to CI (#51429)" (flutter/engine#51432) 2024-03-14 flar@google.com Add DisplayList Region and Transform benchmarks to CI (flutter/engine#51429) 2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 2bc8b222d01f to 70ca2323a702 (1 revision) (flutter/engine#51430) 2024-03-14 matanlurey@users.noreply.github.com Reduce code-duplication a bit and add more error context across `SkiaGoldClient`. (flutter/engine#51426) 2024-03-14 zanderso@users.noreply.github.com [et] build and run commands disable RBE with a flag or when not available (flutter/engine#51404) 2024-03-14 matej.knopp@gmail.com Fix flakiness in FlutterVSyncWaiterTest.VSyncWorks and FlutterDisplayLinkTest.WorkaroundForFB13482573 (flutter/engine#51405) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
Belated LGTM. Thanks @matanlurey for the cleanup! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringBuffer()..writeln('stdout: ...')with a singleSkiaGoldProcessErrorconstructor./cc @dnfield @jonahwilliams FYI only.