This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] cleanup and test vk image usage flags. #51301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Mar 9, 2024
| } | ||
|
|
||
| if (usage & static_cast<TextureUsageMask>(TextureUsage::kShaderRead)) { | ||
| vk_usage |= vk::ImageUsageFlagBits::eSampled; | ||
| // Device transient images can only be used as attachments. The caller |
There was a problem hiding this comment.
Removed overly defensive code. Since we have validation layers we should let this cause problems and have validation fix them (or error here), but not remove the request flags to fix validation
jonahwilliams
commented
Mar 9, 2024
| } | ||
| vk_usage |= vk::ImageUsageFlagBits::eInputAttachment; |
There was a problem hiding this comment.
We don't attach depth/stencil, only the color textures (actually, only the MSAA one, maybe I can fix that too).
…engine into render_target_cache_scope
matanlurey
approved these changes
Mar 13, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 13, 2024
…145113) flutter/engine@c889344...d65c7e4 2024-03-13 john@johnmccutchan.com Small improvements to et lint command (flutter/engine#51372) 2024-03-13 jonahwilliams@google.com [Impeller] cleanup and test vk image usage flags. (flutter/engine#51301) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanups to the vk::ImageUsageFlagBits