Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Increment depth when applying blur style clip in the Gaussian blur. #51189

Closed
wants to merge 1 commit into from

Conversation

bdero
Copy link
Member

@bdero bdero commented Mar 5, 2024

In the old clip stack, clip depth needs to increments/decrement when appending a clip to the current clip stack. Without this change, the applied clips happen to appear inverted.

This happens to also be fixed by enabling StC because the new clip system's depth works differently and doesn't need the increment: #50856

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member

Isn't this obsolete now after STC?

@bdero
Copy link
Member Author

bdero commented Mar 8, 2024

Yeah assuming we don't revert. Closing this for now.

@bdero bdero closed this Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants