Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add instructions for getting code coverage in Android Studio #51105

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Feb 29, 2024

small readme change, because for whatever reason we need to apply the comment from this hero robolectric/robolectric#3023 (comment) to make code coverage work

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall marked this pull request as ready for review February 29, 2024 23:22
@gmackall gmackall requested a review from matanlurey February 29, 2024 23:23
@gmackall gmackall changed the title how to get code coverage working Add instructions for getting code coverage in Android Studio Feb 29, 2024
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great addition!

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2024
@auto-submit auto-submit bot merged commit 0db468f into flutter:main Mar 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 1, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 1, 2024
…144448)

flutter/engine@6f80444...0db468f

2024-03-01 34871572+gmackall@users.noreply.github.com Add instructions for getting code coverage in Android Studio (flutter/engine#51105)
2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 139461270500 to 01d9566c4db8 (1 revision) (flutter/engine#51093)
2024-02-29 skia-flutter-autoroll@skia.org Manual roll Dart SDK from fdf4a62bd07b to 728fcf0bcbca (3 revisions) (flutter/engine#51098)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants