This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Process FlutterMacOS.framework before creating xcframework #51023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
9 tasks
jmagman
approved these changes
Feb 28, 2024
vashworth
added
the
autosubmit
gaaclarke
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
91898e3972 Process FlutterMacOS.framework before creating xcframework (flutter/engine#51023) c873ade1f1 Roll Skia from a55a65d65378 to d591703635b0 (1 revision) (flutter/engine#51046) 3feed45f0b Roll Skia from cce35b54379c to a55a65d65378 (3 revisions) (flutter/engine#51045) 886ff23042 Roll Dart SDK from 44af84628b90 to 7896a944fe67 (1 revision) (flutter/engine#51043) fa691b8cee Roll Skia from a673ab63fccc to cce35b54379c (3 revisions) (flutter/engine#51036)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
Reland #143244. It was reverted due to #144251, which is fixed by flutter/engine#51023.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process (including stripping) FlutterMacOS.framework before creating it as an xcframework.
Should fix flutter/flutter#144251.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.