This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Reland 3: Multiview pipeline (#49950)" #50929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
This reverts commit 9409b75.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Feb 23, 2024
|
Let's pause the revert and wait for a little longer. |
dkwingsmt
deleted the
revert_9409b75e8f35c53e6937a8e7e98b101372a95096
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 24, 2024
…144068) flutter/engine@9409b75...ca24520 2024-02-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland 3: Multiview pipeline (#49950)" (flutter/engine#50929) 2024-02-23 dnfield@google.com Remove timeouts from CountdownLatch.await in tests (flutter/engine#50930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #49950
Initiated by: dkwingsmt
Reason for reverting: Head redness
Original PR Author: dkwingsmt
Reviewed By: {loic-sharma}
This change reverts the following previous change:
Original Description:
This is the 3rd attempt to land multiview pipeline, following #47239.
The pipeline now properly implements the required logic for
scheduleWarmUpFrameto work in a multi-view setup, following the preparation in flutter/flutter#143290 and #50570.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.