Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Re-land] Remove WindowManager reflection in SingleViewPresentation.java #50890

Merged
merged 13 commits into from
Mar 4, 2024

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Feb 22, 2024

relands #49996

Context b/326363243

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall changed the title Revert "Reverts "Remove WindowManager reflection in SingleViewPresent… [Re-land] Remove WindowManager reflection in SingleViewPresentation.java Feb 22, 2024
@CaseyHillers CaseyHillers requested a review from jiahaog February 23, 2024 00:05
Copy link
Member

@jiahaog jiahaog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gmackall gmackall marked this pull request as ready for review February 26, 2024 19:26
@gmackall
Copy link
Member Author

gmackall commented Mar 4, 2024

Updating branch one more time to refresh frob testing before landing

@gmackall
Copy link
Member Author

gmackall commented Mar 4, 2024

Updating again because the last update made it disappear from frob

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2024
@auto-submit auto-submit bot merged commit bd01246 into flutter:main Mar 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 5, 2024
…144581)

flutter/engine@728aa4e...d514a30

2024-03-04 jason-simmons@users.noreply.github.com [Impeller] Fix string comparison in MockGLES.CanInitialize test (flutter/engine#51181)
2024-03-04 34871572+gmackall@users.noreply.github.com [Re-land] Remove WindowManager reflection in SingleViewPresentation.java (flutter/engine#50890)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants