[Impeller] cache onscreen render targets.

[jonahwilliams]

Currently we cache render pass objects to offscreen render targets only. Caching onscreen doesn't work as 1) the render targets are stored on the texture_vk object and 2) the texture_vk object is recreated for each frame (see https://github.com/flutter/engine/blob/main/impeller/renderer/backend/vulkan/surface_vk.cc#L14 ).

To make sure the render pass is cached, move the storage to the texture source.

part of flutter/flutter#141750

[jonahwilliams]

@dnfield Test added

[jonahwilliams]

revert: breaking flutter tester --enable-impeller workflow.

[auto-submit]

A reason for requesting a revert of flutter/engine/50751 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

[jonahwilliams]

Reason for revert: breaking flutter tester --enable-impeller workflow

[dnfield]

Process 95900 stopped
* thread #16, name = 'Queue<0x155e06ab0>', stop reason = EXC_BAD_ACCESS (code=1, address=0x7d)
    frame #0: 0x00000001031baef8 flutter_tester`vk::ImageView::clear(VkClearValue const&, unsigned int, VkRect2D const&) [inlined] vk::Image::getImageType(this=0x0000000000000061) const at VkImage.hpp:84:44 [opt]
   81  		uint32_t getLastLayerIndex(const VkImageSubresourceRange &subresourceRange) const;
   82  		uint32_t getLastMipLevel(const VkImageSubresourceRange &subresourceRange) const;
   83  	
-> 84  		VkImageType getImageType() const { return imageType; }
   85  		const Format &getFormat() const { return format; }
   86  		Format getFormat(VkImageAspectFlagBits aspect) const;
   87  		uint32_t getArrayLayers() const { return arrayLayers; }
Target 0: (flutter_tester) stopped.
warning: flutter_tester was compiled with optimization - stepping may behave oddly; variables may not be available.
(lldb) bt
* thread #16, name = 'Queue<0x155e06ab0>', stop reason = EXC_BAD_ACCESS (code=1, address=0x7d)
  * frame #0: 0x00000001031baef8 flutter_tester`vk::ImageView::clear(VkClearValue const&, unsigned int, VkRect2D const&) [inlined] vk::Image::getImageType(this=0x0000000000000061) const at VkImage.hpp:84:44 [opt]
    frame #1: 0x00000001031baef8 flutter_tester`vk::ImageView::clear(this=0x0000600001eb1fe8, clearValue=0x00006000020c8160, aspectMask=4, renderArea=0x0000600001980108) at VkImageView.cpp:187:2 [opt]
    frame #2: 0x000000010319c048 flutter_tester`vk::Framebuffer::executeLoadOp(this=0x0000600003484578, renderPass=0x0000600001eb2e88, clearValueCount=<unavailable>, pClearValues=<unavailable>, renderArea=0x0000600001980108) at VkFramebuffer.cpp:126:19 [opt]
    frame #3: 0x00000001031a736c flutter_tester`vk::CommandBuffer::submit(this=0x00006000019800b8, executionState=0x000000017062e800) at VkCommandBuffer.cpp:2330:12 [opt]
    frame #4: 0x00000001031ade98 flutter_tester`vk::Queue::submitQueue(this=0x0000000155e06ab0, task=<unavailable>) at VkQueue.cpp:104:42 [opt]
    frame #5: 0x00000001031ad67c flutter_tester`vk::Queue::taskLoop(this=0x0000000155e06ab0, scheduler=<unavailable>) at VkQueue.cpp:156:4 [opt]
    frame #6: 0x00000001031aeb48 flutter_tester`void* std::_fl::__thread_proxy[abi:v15000]<std::_fl::tuple<std::_fl::unique_ptr<std::_fl::__thread_struct, std::_fl::default_delete<std::_fl::__thread_struct>>, void (vk::Queue::*)(marl::Scheduler*), vk::Queue*, marl::Scheduler*>>(void*) [inlined] decltype(*std::declval<vk::Queue*>().*std::declval<void (vk::Queue::*)(marl::Scheduler*)>()(std::declval<marl::Scheduler*>())) std::_fl::__invoke[abi:v15000]<void (vk::Queue::*)(marl::Scheduler*), vk::Queue*, marl::Scheduler*, void>(__f=0x00006000034b0698, __a0=0x00006000034b06a8, __args=0x00006000034b06b0) at invoke.h:368:23 [opt]
    frame #7: 0x00000001031aeb28 flutter_tester`void* std::_fl::__thread_proxy[abi:v15000]<std::_fl::tuple<std::_fl::unique_ptr<std::_fl::__thread_struct, std::_fl::default_delete<std::_fl::__thread_struct>>, void (vk::Queue::*)(marl::Scheduler*), vk::Queue*, marl::Scheduler*>>(void*) [inlined] void std::_fl::__thread_execute[abi:v15000]<std::_fl::unique_ptr<std::_fl::__thread_struct, std::_fl::default_delete<std::_fl::__thread_struct>>, void (vk::Queue::*)(marl::Scheduler*), vk::Queue*, marl::Scheduler*, 2ul, 3ul>(__t=0x00006000034b0690, (null)=<unavailable>) at thread:284:5 [opt]
    frame #8: 0x00000001031aeb28 flutter_tester`void* std::_fl::__thread_proxy[abi:v15000]<std::_fl::tuple<std::_fl::unique_ptr<std::_fl::__thread_struct, std::_fl::default_delete<std::_fl::__thread_struct>>, void (vk::Queue::*)(marl::Scheduler*), vk::Queue*, marl::Scheduler*>>(__vp=0x00006000034b0690) at thread:295:5 [opt]
    frame #9: 0x00000001819be034 libsystem_pthread.dylib`_pthread_start + 136

[dnfield]

This particular test is using the "live" binding. Something's not keeping the vk objects alive long enough I think.