Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make all Android scenario_app activities full-screen, even on older Android versions. #50666

Merged

Conversation

matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Feb 14, 2024

Work towards flutter/flutter#143471.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #50666 at sha d622d87

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024
@auto-submit auto-submit bot merged commit e9a012c into flutter:main Feb 14, 2024
sealesj pushed a commit to sealesj/engine that referenced this pull request Feb 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 16, 2024
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647)
2024-02-15 flar@google.com [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635)
2024-02-15 ditman@gmail.com [web] Add dynamic view sizing (v2) (flutter/engine#50271)
2024-02-14 matanlurey@users.noreply.github.com Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667)
2024-02-14 34871572+gmackall@users.noreply.github.com Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664)
2024-02-14 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613)
2024-02-14 matanlurey@users.noreply.github.com Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666)
2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660)
2024-02-14 matanlurey@users.noreply.github.com Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623)
2024-02-14 mdebbar@google.com [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647)
2024-02-15 flar@google.com [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635)
2024-02-15 ditman@gmail.com [web] Add dynamic view sizing (v2) (flutter/engine#50271)
2024-02-14 matanlurey@users.noreply.github.com Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667)
2024-02-14 34871572+gmackall@users.noreply.github.com Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664)
2024-02-14 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613)
2024-02-14 matanlurey@users.noreply.github.com Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666)
2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660)
2024-02-14 matanlurey@users.noreply.github.com Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623)
2024-02-14 mdebbar@google.com [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App will affect goldens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants